I'm not a user of sitecopy myself, just trying to help....
By *looking* at the code, I'm *guessing* that the problem arises from that
the program seem to rewrite a site-wide XML file each time something happens.
There seems to be a big risk that the program is interrupted while rewriting
the XML file (which will leave it corrupt).
By writing to a temporary (*.pending) file, and - when done - moving it to
(overwriting) the real location we can probably avoid this.
(Another possible solution would be to catch signals and make sure to delay
the program from exiting until we're done with whatever we are doing.)
Could someone who's familiar with sitecopy (and the problem?) please try the
attached patch and see if it solves the problem?
Please be careful, I have not tested these changes at all!
Regards,
Andreas Henriksson
diff -uriNp sitecopy-0.16.3/src/sitestore.c
sitecopy-0.16.3-pending/src/sitestore.c
--- sitecopy-0.16.3/src/sitestore.c 2006-02-04 11:18:08.000000000 +0100
+++ sitecopy-0.16.3-pending/src/sitestore.c 2008-06-08 21:56:23.000000000
+0200
@@ -60,17 +60,42 @@
/* Opens the storage file for writing */
FILE *site_open_storage_file(struct site *site)
{
+ char filebuf[PATH_MAX];
+
+ /* open a temporary "pending" file, to not corrupt the site file in case
+ * the program aborts while we are updating it.
+ * The site_close_storage_file() function will rename it to it's proper
+ * name.
+ * FIXME: something should clean up old *.pending files,
+ * which never got properly closed.
+ */
+ snprintf(filebuf, sizeof(filebuf), "%s.pending", site->infofile);
+
if (site->storage_file == NULL) {
- site->storage_file = fopen(site->infofile, "w" FOPEN_BINARY_FLAGS);
+ site->storage_file = fopen(filebuf, "w" FOPEN_BINARY_FLAGS);
}
return site->storage_file;
}
int site_close_storage_file(struct site *site)
{
- int ret = fclose(site->storage_file);
+ char filebuf[PATH_MAX];
+ int err;
+
+ /* close filehandle */
+ err = fclose(site->storage_file);
site->storage_file = NULL;
- return ret;
+ if (err) {
+ perror("fclose");
+ return err;
+ }
+
+ /* rename pending file to real filename (overwriting existing file). */
+ snprintf(filebuf, sizeof(filebuf), "%s.pending", site->infofile);
+ err = rename(filebuf, site->infofile);
+ if (err)
+ perror("rename");
+ return err;
}
/* Return escaped form of 'filename'; any XML-unsafe characters are
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
