Package: dhcp3
Version: 3.1.1-1
Severity: minor
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu ubuntu-patch intrepid

Hi,

please consider using the standard LSB message functions in the init
script instead of echo. That will make dhcp3 server work with boot
splash, boot loggers, etc.

In addition to attached patch (which changes the init script), you
need to add a "lsb-base" dependency to dhcp3-server, to ensure that
/lib/lsb/init-functions is available.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
Remember to add Depends: lsb-base to dhcp3-server

--- debian/dhcp3-server.init.d.orig	2008-06-16 15:52:02.000000000 +0200
+++ debian/dhcp3-server.init.d	2008-06-16 15:57:07.000000000 +0200
@@ -26,6 +26,8 @@
 	exit 0
 fi
 
+. /lib/lsb/init-functions
+
 # Read init script configuration (so far only interfaces the daemon
 # should listen on.)
 . /etc/default/dhcp3-server
@@ -63,23 +65,24 @@
 case "$1" in
 	start)
 		test_config
-		echo -n "Starting $DESC: "
+		log_daemon_msg "Starting $DESC" "$NAME"
 		start-stop-daemon --start --quiet --pidfile $DHCPDPID \
 			--exec /usr/sbin/dhcpd3 -- -q $INTERFACES
 		sleep 2
 
 		if check_status -q; then
-			echo "$NAME."
+			log_end_msg 0
 		else
-			echo "$NAME failed to start - check syslog for diagnostics."
+			log_failure_msg "check syslog for diagnostics."
+			log_end_msg 1
 			exit 1
 		fi
 		;;
 	stop)
-		echo -n "Stopping $DESC: $NAME"
+		log_daemon_msg "Stopping $DESC" "$NAME"
 		start-stop-daemon --stop --quiet --pidfile $DHCPDPID
+		log_end_msg $?
 		rm -f "$DHCPDPID"
-		echo "."
 		;;
 	restart | force-reload)
 		test_config

Attachment: signature.asc
Description: Digital signature

Reply via email to