Bug#488249: gnome-system-tools: unable to create a group

[James Westby]

Package: gnome-system-tools
Version: 2.22.0-1
Severity: normal
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu intrepid ubuntu-patch
Forwarded: http://bugzilla.gnome.org/show_bug.cgi?id=529228

Hi,

gnome-system-tools is unable to create groups. for details please
see

  http://bugzilla.gnome.org/show_bug.cgi?id=529228

and

  https://bugs.edge.launchpad.net/gst/+bug/205144

Attached is a patch to fix this issue. Please consider applying it.

Thanks,

James


Index: ubuntu/src/users/callbacks.c
===================================================================
--- ubuntu.orig/src/users/callbacks.c	2008-06-24 17:04:49.000000000 +0100
+++ ubuntu/src/users/callbacks.c	2008-06-24 17:06:51.000000000 +0100
@@ -414,7 +414,7 @@
 	response = group_settings_dialog_run (dialog, group);
 
 	if (response == GTK_RESPONSE_OK) {
-		group_settings_dialog_get_data (group);
+		group = group_settings_dialog_get_group ();
 
 		config = OOBS_GROUPS_CONFIG (GST_USERS_TOOL (tool)->groups_config);
 		groups_list = oobs_groups_config_get_groups (config);
Index: ubuntu/src/users/group-settings.c
===================================================================
--- ubuntu.orig/src/users/group-settings.c	2008-06-24 12:04:27.000000000 +0100
+++ ubuntu/src/users/group-settings.c	2008-06-24 17:06:51.000000000 +0100
@@ -341,3 +341,19 @@
 
 	group_members_table_save (group);
 }
+
+OobsGroup*
+group_settings_dialog_get_group (void)
+{
+	GtkWidget *widget;
+	OobsGroup *group;
+
+	widget = gst_dialog_get_widget (tool->main_dialog, "group_settings_name");
+	group  = oobs_group_new(gtk_entry_get_text (GTK_ENTRY (widget)));
+	widget = gst_dialog_get_widget (tool->main_dialog, "group_settings_gid");
+	oobs_group_set_gid (group, gtk_spin_button_get_value (GTK_SPIN_BUTTON (widget)));
+
+	group_members_table_save (group);
+  
+	return group;
+}
Index: ubuntu/src/users/group-settings.h
===================================================================
--- ubuntu.orig/src/users/group-settings.h	2008-06-24 12:04:27.000000000 +0100
+++ ubuntu/src/users/group-settings.h	2008-06-24 17:06:51.000000000 +0100
@@ -37,6 +37,7 @@
 
 gid_t        group_settings_find_new_gid        (void);
 void         group_settings_dialog_get_data     (OobsGroup    *group);
+OobsGroup*   group_settings_dialog_get_group    (void);
 
 
 #endif /* __GROUP_SETTINGS_H */