reopen 478593
thanks

On Wed, Jul 09, 2008 at 08:51:03PM +0000, Debian Bug Tracking System wrote:
> The current version 3.1.5 is already being careful when stopping the 
> process. I'd say the bug is fixed.

It's not really "already" :) but yes, it fixes most of the bug that I
reported because it's not being overly smart any more.

But, I see one part of the bug left over in it: in the case where
pdns_recursor isn't killed because it's not found, it doesn't show the
message, because it runs start-stop-daemon --stop --oknodo, which means
that it will always exit with code 0 (because of --oknodo).

The fix remains similar to what I originally proposed:

--- pdns-recursor.orig  2008-07-09 23:22:02.000000000 +0200
+++ pdns-recursor       2008-07-09 23:22:26.000000000 +0200
@@ -50,8 +50,11 @@
 }
 
 stop() {
-  start-stop-daemon --stop --oknodo --quiet --retry=TERM/5/KILL/5 --pidfile 
$PIDFILE --name $NAME
+  set +e
+  start-stop-daemon --stop --quiet --retry=TERM/5/KILL/5 --pidfile $PIDFILE 
--name $NAME
+  RET=$?
   rm -f $PIDFILE       # just in case
+  return $RET
 }
 
 stop_resolvconf() {

Please fix this then. TIA.

-- 
     2. That which causes joy or happiness.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to