Brad Sawatzky <[EMAIL PROTECTED]> wrote: Hi,
> The patch fixes this problem by making a copy of the option name and > setting menu_items[].label to point to the new string (removing xsane's > dependence on a volatile memory structure). Good and bad news. Good: - I can reproduce the issue here (a bit differently, but it's the same issue) - the changes (and bugs :)) I made to the net backend helped pinpoint the issue over the past few weeks Bad: - I think your patch may be the best option to fix this issue... - ... but I'm afraid it may be leaking memory Bug goes like this: - XSane sets an option triggering a reload - ... but doesn't care about that (passing info = NULL) - net backend reloads the options on its own - memory references have changed - you're lucky or you're not. Also, it applies to all backends, not just the epsons. I'm experiencing it with the snapscan backend. Could you rework your patch to free the memory you're allocating when the option menu is rebuilt? With that done, I can apply it to XSane. I'm also thinking about another approach, using a pointer to the pointer stored inside the option descriptor. That'll take one more dereference before using it, but that'll save the memory allocation. However I'll go for the memory allocation right now, as it's mostly ready. JB. -- Julien BLACHE - Debian & GNU/Linux Developer - <[EMAIL PROTECTED]> Public key available on <http://www.jblache.org> - KeyID: F5D6 5169 GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
