On Sun, Aug 10, 2008 at 12:13:04PM +0200, Elimar Riesebieter wrote: > On Thu, 07 Aug 2008 the mental interface of > Nico Golde told: > > > Package: moc > > Version: 1:2.5.0~alpha3+svn20080629-1 > > Severity: important > > > > Hi Elimar! > > I have a problem with mocp. > [...] > > > > Now if I open mocp in my music directory and add an interpret > > directory to the playlist by using 'a' mocp immediately crashes > > writing 'FATAL_ERROR: Can't send() int to the server.' > > This bug was introduced with svn r2068: > "Tags cache using BerkeleyDB...." > > r2067 works fine, so I tried to build against libdb4.[2-7], but > always crashes on my amd64. I've testet i586 and ppc as well. Both > are working!
Thanks, this is really a valuable information. Since I don't have any 64bit box, I've reviewed the cache code and found one possible problem. The patch is attached. Can you try it? -- Damian Pietras
Index: tags_cache.c =================================================================== --- tags_cache.c (revision 2096) +++ tags_cache.c (working copy) @@ -165,7 +165,7 @@ *len = sizeof(rec->mod_time) + sizeof(rec->atime) - + sizeof(int) * 3 /* lenghts of title, artist, time. */ + + sizeof(size_t) * 3 /* lenghts of title, artist, time. */ + artist_len + album_len + title_len
