Package: goobox
Version: 2.0.0-2
Severity: normal
Tags: patch
Goobox crashes after the following steps:
1. Select WAV output format in the Preferences dialog
2. Close and re-open the dialog
3. The Properties button is now enabled, click it.
The attached makes sure the Properties button is disabled for WAV
files. It also fixes the cause of the segfault, in case somebody
manages to activate that button in a different way :)
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.26-1-amd64 (SMP w/1 CPU core)
Locale: LANG=nl_BE.UTF-8, LC_CTYPE=nl_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages goobox depends on:
ii gconf2 2.22.0-1 GNOME configuration database syste
ii gnome-media 2.22.0-3 GNOME media utilities
ii gstreamer0.10-gnomevfs 0.10.20-1 GStreamer plugin for GnomeVFS
ii gstreamer0.10-plugins-base 0.10.20-1 GStreamer plugins from the "base"
ii libart-2.0-2 2.3.20-2 Library of functions for 2D graphi
ii libatk1.0-0 1.22.0-1 The ATK accessibility toolkit
ii libbonobo2-0 2.22.0-1 Bonobo CORBA interfaces library
ii libbonoboui2-0 2.22.0-1 The Bonobo UI library
ii libc6 2.7-13 GNU C Library: Shared libraries
ii libcairo2 1.6.4-6 The Cairo 2D vector graphics libra
ii libdbus-1-3 1.2.1-3 simple interprocess messaging syst
ii libdbus-glib-1-2 0.76-1 simple interprocess messaging syst
ii libgcc1 1:4.3.1-9 GCC support library
ii libgconf2-4 2.22.0-1 GNOME configuration database syste
ii libglade2-0 1:2.6.2-1 library to load .glade files at ru
ii libglib2.0-0 2.16.5-1 The GLib library of C routines
ii libgnome2-0 2.20.1.1-1 The GNOME 2 library - runtime file
ii libgnomecanvas2-0 2.20.1.1-1 A powerful object-oriented display
ii libgnomeui-0 2.20.1.1-1 The GNOME 2 libraries (User Interf
ii libgnomevfs2-0 1:2.22.0-4 GNOME Virtual File System (runtime
ii libgstreamer0.10-0 0.10.20-1 Core GStreamer libraries and eleme
ii libgtk2.0-0 2.12.11-3 The GTK+ graphical user interface
ii libice6 2:1.0.4-1 X11 Inter-Client Exchange library
ii libmusicbrainz4c2a 2.1.5-2 Second generation incarnation of t
ii libnotify1 [libnotify1-gtk 0.4.4-3 sends desktop notifications to a n
ii liborbit2 1:2.14.13-0.1 libraries for ORBit2 - a CORBA ORB
ii libpango1.0-0 1.20.5-1 Layout and rendering of internatio
ii libpopt0 1.14-4 lib for parsing cmdline parameters
ii libsm6 2:1.0.3-2 X11 Session Management library
ii libstdc++6 4.3.1-9 The GNU Standard C++ Library v3
ii libx11-6 2:1.1.4-2 X11 client-side library
ii libxml2 2.6.32.dfsg-2 GNOME XML library
Versions of packages goobox recommends:
ii dbus-x11 1.2.1-3 simple interprocess messaging syst
ii gstreamer0.10-plugins-good 0.10.8-4 GStreamer plugins from the "good"
ii yelp 2.22.1-6 Help browser for GNOME 2
Versions of packages goobox suggests:
ii gstreamer0.10-lame 0.10.6-0.1 GStreamer lame plugins
-- no debconf information
--- a/src/dlg-preferences.c
+++ b/src/dlg-preferences.c
@@ -368,6 +368,7 @@
gtk_combo_box_set_active (GTK_COMBO_BOX (data->p_filetype_combobox),
file_format);
gtk_notebook_set_current_page (GTK_NOTEBOOK
(data->p_encoding_notebook), file_format);
+ gtk_widget_set_sensitive (data->p_filetype_properties_button,
file_format != GOO_FILE_FORMAT_WAVE);
/**/
@@ -583,7 +584,7 @@
text = g_strdup_printf ("<big><b>%s</b></big>", _("FLAC"));
break;
default:
- text = "";
+ text = g_strdup("");
break;
}
gtk_label_set_markup (GTK_LABEL (f_title_label), text);
@@ -597,6 +598,7 @@
text = _("Compression level:");
break;
default:
+ text = "";
break;
}
gtk_label_set_text (GTK_LABEL (data->f_quality_label), text);
@@ -612,6 +614,7 @@
text = _("WAV+PCM is a lossless format that holds uncompressed,
raw pulse-code modulated (PCM) audio.");
break;
default:
+ text = "";
break;
}
gtk_label_set_text (GTK_LABEL (f_description_label), text);
