Package: git-core
Version: 1:1.4.4.4-2

The manpage git-format-patch says
       --in-reply-to=Message-Id

So I ran this command in a git tree:
  git-format-patch -s --thread -n -o d --in-reply-to='<[EMAIL PROTECTED]>' 
upstream

The resulting messages in the d/ directory said things like this:
  In-Reply-To: <<[EMAIL PROTECTED]>>

The Message-ID is a concept defined by RFC2822, et al.  It _includes_
the delimiting angle brackets.  From RFC2822:
  message-id      =       "Message-ID:" msg-id CRLF
  msg-id          =       [CFWS] "<" id-left "@" id-right ">" [CFWS]

So there is a bug here: the code does not accept an actual message-id,
only the `mailbox' part of the message-id syntax production (ie the
message-id stripped of its angle brackets).

This could be fixed by changing the documentation - that is, to
document the bug, but it would be better for --in-reply-to to strip
the < >s itself (or, depending how you look at it, to only add them
if they're not already present).

Ian.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to