Hi Stefan, On Fri, Sep 05, 2008 at 01:49:26PM +0200, Stefan Bender wrote: > When one sets "timedisplay-type = remaining" in the config, > ncmpc will crash with a strange looking libc memory corruption > error. > > I found the reason to be the initialisation of the variable > options.timedisplay_type in src/options.c:371, which does not > work as expected, if at all. > > When one sets "timedisplay-type = remaining" in the config, the > g_free() in src/conf.c:477 fails because there is no memory > allocated but options.timedisplay_type != NULL, this gives > the libc errors. > > The solution is to use g_strdup() to allocate the memory for > the string. I have attached a patch vs. the current svn > revision (7398), but it applied to the debian sources as well.
Thanks for the patch! It looks fine, so I will include it in the next upload. > I also sent this report to upstream, but there was no action (yet): > > http://www.musicpd.org/mantis/view.php?id=1720 Yeah, upstream is dead, basically ... :-/ Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
