On Tue 09 Sep 2008, Simone Tampieri wrote:
> Hello.
> I'm not so expert, but could to be a bug.
>
> The rsync daemon config file (/etc/rsyncd.conf) seem get commented
> line also if the hash is in the middle (#) of config line.
Thanks for your report.
I've confirmed what you see, but if you read the manpage for
rsyncd.conf, it only talks about lines that _begin_ with a '#' as
comment lines.
> Example:
> In your rsyncd.conf you have 2 modules.
> * list option is on true by default, then they appear when you log
> in with rsync.
> Now in ONE module put the line "list=no", and you will see that at
> rsync log in you can't see the module. That's ok.
> Now you can edit the line writing "list=no # comment" and if
> you relog with rsync you can see the module again, also if you have
> the list option setted on "no".
In this case, what actually happens is that the value for the setting
"list" becomes "no # comment", and that's not equal to "no" ;-)
The reason that '#" is not used to indicate a comment after a value,
is to make it easier to use '#' e.g. as part of a filename, such as:
[module1]
path = /extra/dir#1
[module2]
path = /extra/dir#2
I admit that it's not quite what you might expect, especially with
"list" line, but I think it would make the code unnecessarily complex to
only allow this type of comment for certain lines, and not for others.
It would also be inconsistent from a user point of view, if it only
worked sometimes...
Perhaps the manpage could be made a bit more clear on this point.
> It seem that a comment in line middle to comment ALL the line, not
> just at beginning as wrote on man page.
The effect is not to comment the whole line, but to change the value
"no" into something else.
Paul Slootman
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
