Tags: patch
Hello,
I repaired the image preview in jumpnbump-menu and corrected tempdirectory
usage. Before jumpnbump-menu overwrote random files in temp without
checking ownership.
Greetings,
Kilian Kilger.
diff --git a/jumpnbump_menu/jumpnbump_menu.py b/jumpnbump_menu/jumpnbump_menu.py
index a1ae6fa..cf585c1 100644
--- a/jumpnbump_menu/jumpnbump_menu.py
+++ b/jumpnbump_menu/jumpnbump_menu.py
@@ -13,6 +13,8 @@ import gtk.glade
import gtk.gdk
import gobject
import os
+import tempfile
+import shutil
RESOURCE_DIR='/usr/share/games/jumpnbump'
BINARY_DIR='/usr/games'
@@ -81,14 +83,16 @@ def level_changed (widget):
global choosen_level
choosen_level = '%s/%s' % (RESOURCE_DIR, model.get_value (iter, 0))
try:
- os.chdir ('/tmp')
- os.spawnlp (os.P_WAIT, 'jumpnbump-unpack', 'jumpnbump', choosen_level)
+ jumpnbumpdir = tempfile.mkdtemp ("jumpnbumpmenu")
+ os.chdir(jumpnbumpdir)
+ os.spawnlp (os.P_WAIT, '/usr/lib/jumpnbump/unpack', 'unpack', choosen_level)
os.spawnlp (os.P_WAIT, 'convert', 'convert', '-scale', '50%', 'level.pcx', 'level_scaled.pcx')
os.spawnlp (os.P_WAIT, 'convert', 'convert', 'level_scaled.pcx', 'level.png')
+ image.set_from_file ('level.png')
+ shutil.rmtree(jumpnbumpdir)
except Exception, err:
print err
- image.set_from_file ('/tmp/level.png')
image.show()
def about (widget):
