package efax-gtk tag 267484 patch tag 267484 pending thanks So can we agree on a patch for version 3.0.2 in Debian and a UI option in later versions?
Daniel, I'll need your approval. I'd like to upload version 3.0.2 to SID soon. Chris Vine wrote: > On Friday 10 June 2005 23:35, Lior Kaplan wrote: > >>Hi Chris, >> >>Please see this as a feature request to hide the calling card code while >>sending faxes (log & recipient). >> >>Thanks >>Lior Kaplan >>Debian maintainer for efax-gtk package >> >>Daniel Webb wrote: >> >>>On Sat, Jun 11, 2005 at 12:14:17AM +0300, Lior Kaplan wrote: >>> >>>>Did you check that the recipient get your PID? or that's something that >>>>only goes for the log? >>> >>>I sent a fax and verified that the line at the top of the fax looks >>>exactly like the line in the log (and thus, includes my calling-card >>>PIN). > > > Hi, > > This is a relatively easy fix provided there is some method of identifying > the > text which must be excluded. > > Do you have any suggestions about this? Is there any particular format > attaching to the "calling card" ID? I imagine different countries probably > do it differently. > > The easiest approach therefore is to have an option to omit all the dialed > number information from the fax top header line. > > If Daniel doesn't mind recompiling, for a temporary fix he can go to line 109 > in file efax_controller.cpp which is as follows: > > temp += last_fax_item_sent.number + " p.%d/%d"; > > and change it to: > > temp += " p.%d/%d"; > > It is line 109 in efax-gtk-3.0.2, and will be the same or around the same in > efax-gtk-3.0.1. It will exclude the dialled number from the top header line > in every case. > > My proposal would involve have a setting in the settings dialog which would > make this an option. > > Chris > -- Regards, Lior Kaplan [EMAIL PROTECTED] http://www.Guides.co.il Debian GNU/Linux unstable (SID) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
