Hi Adam,
Adam D. Barratt wrote:
Hi,
On Thu, 2008-09-18 at 19:39 -0400, Eric Gerlach wrote:
Admission: That second patch was horribly broken.
I've attached a third patch, this one actually works on git repositories
*with* commits too.
Just a quick note to let you know that we're not ignoring your
patch. :-)
Of course. I figured that since Lenny's in freeze it won't be going in
until after release.
I've got a local copy of debcommit with a slightly revised patch (using
exit status rather than attempting to parse the output) that works great
for commits and "debcommit --diff $file" but haven't found a method that
works properly for "debcommit --diff" yet.
I believe you're misinterpreting the purpose of my patch. It doesn't
fix the '--diff' case (which, now that I've looked at the code, is
broken too... I just never tried it).
This patch fixes the getmessage() function in the case of an empty git
repo. Since it only operates on one file (debian/changelog), using
"diff -u /dev/null" works fine.
I decided to parse the output rather than take the exit status to avoid
having git print the sha1 on the screen (user shouldn't have to see
that). You could redirect stdout/stderr and use system() rather than
qx{}, and I tried that initially, but the code was just too ugly IMHO.
Doesn't matter to me which version ends up in the package, but my
version's already done. :-)
Cheers,
--
Eric Gerlach, Network Administrator
Federation of Students
University of Waterloo
p: (519) 888-4567 x36329
e: [EMAIL PROTECTED]
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
