Package: munin-node
Version: 1.2.6-7
Severity: minor
Tags: patch
Hi,
checking the exit status of a line that ends with '|| true' is kind of
pointless (and the check is bogus too since [ "$?" ] is always true).
Small cleanup patch attached.
-- Guido
>From 4d5958f6f70c03b2b763c01e428a43d25573769d Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= <[EMAIL PROTECTED]>
Date: Wed, 29 Oct 2008 10:11:17 +0100
Subject: [PATCH] pointless check for return value
---
debian/munin-node.postinst | 11 +----------
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/debian/munin-node.postinst b/debian/munin-node.postinst
index 74ae700..65894ce 100644
--- a/debian/munin-node.postinst
+++ b/debian/munin-node.postinst
@@ -26,20 +26,11 @@ init_plugins() {
if [ "$prevver" ]; then
echo -n "Initializing new plugins.."
munin-node-configure --shell --newer "${prevver%-*}" > $TMPFILE || true
- if [ "$?" ] ; then
- sh < $TMPFILE
- else
- echo "failed."
- fi
else
echo -n "Initializing plugins.."
munin-node-configure --shell > $TMPFILE || true
- if [ "$?" ] ; then
- sh < $TMPFILE
- else
- echo "failed."
- fi
fi
+ sh < $TMPFILE
echo "done."
rm $TMPFILE
}
--
1.6.0.1
