Package: squashfs-source
Version: 1:3.3-7
Severity: wishlist
Tags: patch

The following commit[1] to the upstream kernel (part of 2.6.27) changes 
the API for init_once(), as a result squashfs oopses on modprobe.

commit 51cc50685a4275c6a02653670af9f108a64e01cf
Author: Alexey Dobriyan <[EMAIL PROTECTED]>
Date:   Fri Jul 25 19:45:34 2008 -0700

    SL*B: drop kmem cache argument from constructor

    Kmem cache passed to constructor is only needed for constructors that are
    themselves multiplexeres.  Nobody uses this "feature", nor does anybody uses
    passed kmem cache in non-trivial way, so pass only pointer to object.

    Non-trivial places are:
        arch/powerpc/mm/init_64.c
        arch/powerpc/mm/hugetlbpage.c

    This is flag day, yes.

The attached, minimal and well tested, patch adapts to this change, while 
keeping compatibility for older kernels (updating to squashfs 3.4 would 
fix this as well). Severity wishlist, given that testing and l-m-e are
frozen on 2.6.26 anyways.

Regards
        Stefan Lippers-Hollmann

[1]     
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=51cc50685a4275c6a02653670af9f108a64e01cf

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.27-4.slh.2-sidux-amd64 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages squashfs-source depends on:
ii  bzip2                  1.0.5-1           high-quality block-sorting file co
ii  debhelper              7.0.17            helper programs for debian/rules
ii  make                   3.81-5            The GNU version of the "make" util
ii  module-assistant       0.10.11.0         tool to make module package creati
ii  zlib1g-dev             1:1.2.3.3.dfsg-12 compression library - development

Versions of packages squashfs-source recommends:
ii  squashfs-tools        1:3.3-7            Tool to create and append to squas

squashfs-source suggests no packages.

-- no debconf information
--- a/linux-2.6/inode.c
+++ b/linux-2.6/inode.c
@@ -2192,8 +2192,10 @@
 
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,24))
 static void init_once(void * foo, struct kmem_cache * cachep, unsigned long flags)
-#else
+#elif (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,27))
 static void init_once(struct kmem_cache *cachep, void *foo)
+#else
+static void init_once(void *foo)
 #endif
 {
 	struct squashfs_inode_info *ei = foo;

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to