On Fri, 31 Oct 2008, Raphael Geissert wrote:
> Package: dpkg-dev
> Version: 1.14.22
> 
> Attached are the results of running a test suite on Dpkg::Version. The test 
> suite was written to help make sure "equivalents" of dpkg's vercmp do conform 
> with policy and dpkg's own implementation.

What about attaching the code of your test suite?

I would have also expected some more analysis of failures because at first
look I think you reported many non-problems and would rather concentrate
on real problems.

Do you really believe that the code that we're using daily everywhere can
fail 141 times out of 731?

> dpkg-dev.pl failed test 'foo- foo 0'/tests/foo with '1'
> dpkg-dev.pl failed test 'foo- foo+ -1'/tests/foo with '1'

We don't have "foo" packages do we ? However this looks like a real
difference between dpkg --compare-versions and Dpkg::Version::vercmp().

> dpkg-dev.pl failed test '3.3-1.1 3.1-1 1 acl2'/tests/versions.lenny-sid with 
> '2'

Both 1 and 2 are greater than 0 and that's the only thing that matters in
version comparison. Please adjust your test suite accordingly (of course
same goes for negative numbers) and post the updated results.

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to