* Cyril Brulebois ([EMAIL PROTECTED]) wrote: > tag 503298 patch > thanks > > Aron Griffis <[EMAIL PROTECTED]> (24/10/2008): > > I reported this bug upstream over a year ago and it was finally fixed. > > Thanks for having done so. Could you please grab the source package, > apply the attached patch, build it, and confirm it works fine for you? > I'm no such medium to check by myself. > > Eric, would you like me to NMU it to fix this RC bug? If you prefer, you > can of course scratch the NMU line, adjust the version and the trailer > line and upload it yourself.
Thanks Cyril, I'll upload it tomorrow, no need to NMU.
> Some remarks:
> - I included the diff w/o any patch management system to keep the
> changes minimal (I could have used quilt otherwise).
> - I didn't use simple-patchsys.mk either, since it would have
> introduced a failure to build twice in a row, see #414305/#494254.
> - debian/rules should be including the rules include after all other
> class includes. But since no related bug got reported, I'm not
> touching that either.
> - I'm not bumping urgency so that it gets some bits of testing in
> unstable before having a chance to migrate.
>
> Hope this helps.
>
> Mraw,
> KiBi.
> diff -u engine-pkcs11-0.1.4/debian/changelog
> engine-pkcs11-0.1.4/debian/changelog
> --- engine-pkcs11-0.1.4/debian/changelog
> +++ engine-pkcs11-0.1.4/debian/changelog
> @@ -1,3 +1,14 @@
> +engine-pkcs11 (0.1.4-1.1) unstable; urgency=low
> +
> + * Non-maintainer upload.
> + * Backport revision 110 (upstream ticket #11) to fix failure to ask a
> + PIN, often rendering the smartcard locked: check for mycb not being
> + NULL before trying to dereference it, in src/engine_pkcs11.c's
> + get_pin(). Thanks to Aron Griffis for both Debian and upstream bug
> + reports (Closes: #503298).
> +
> + -- Cyril Brulebois <[EMAIL PROTECTED]> Tue, 04 Nov 2008 01:26:45 +0100
> +
> engine-pkcs11 (0.1.4-1) unstable; urgency=low
>
> * New upstream release.
> only in patch2:
> unchanged:
> --- engine-pkcs11-0.1.4.orig/src/engine_pkcs11.c
> +++ engine-pkcs11-0.1.4/src/engine_pkcs11.c
> @@ -105,7 +105,7 @@
> const char *prompt_info;
> } *mycb = callback_data;
>
> - if (mycb->password) {
> + if (mycb != NULL && mycb->password) {
> sc_pin = set_pin(mycb->password);
> return sc_pin;
> }
--
Eric Dorland <[EMAIL PROTECTED]>
ICQ: #61138586, Jabber: [EMAIL PROTECTED]
signature.asc
Description: Digital signature
