retitle 502556 fails on sections names that are invalid regular expression, like Programming/C++ thanks
On Sat, 25 Oct 2008, Karl Hegbloom wrote: Hi, > This patch fixes the problem. RTFM! At first I didn't have any idea why the patch would help; Programming/OCaml seemed to be a perfectly valid regex. It took me a while to realize that Programming/C++ is the problematic section. > + try: > + matcher=re.compile(sect+"/", re.IGNORECASE) > + except re.error: > + matcher=re.compile(re.escape(sect)+"/", re.IGNORECASE) Actually there's a minor flaw in your the patch. doc-base sections shouldn't be treated as regular expressions at all. Even if there is currently no section that both contains regex meta characters, and is a valid regex, I can imagine that such a section name might be added in the future. Thus re.escape() should be used always, not only in case of exception. Regards, Robert -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
