Op 20081114 om 14:58 schreef Xavier Luthi:
> On Fri, Nov 14, 2008 at 12:23:34PM +0000, Chris Halls wrote:

~ ~ ~ --- usr/share/pycentral/apt-proxy/site-packages/apt_proxy/cache.py.orig 
2007-12-07 14:12:28.354666060 +1100
~ ~ ~ +++ usr/share/pycentral/apt-proxy/site-packages/apt_proxy/cache.py 
2007-12-07 14:12:41.618773035 +1100
~ ~ ~ @@ -597,7 +597,7 @@
~ ~ ~          elif re.search(r"\.gz$", self.path):
~ ~ ~              self.worker = FileVerifierProcess(self, '/bin/gunzip', '-t', 
'-v', self.path)
~ ~ ~          elif re.search(r"\.bz2$", self.path):
~ ~ ~ -            self.worker = FileVerifierProcess(self, '/usr/bin/bunzip2', 
'--test', self.path)
~ ~ ~ +            self.worker = FileVerifierProcess(self, '/bin/bunzip2', 
'--test', self.path)
~ ~ ~          else:
~ ~ ~              # Unknown file, just check it is not 0 size
~ ~ ~              try:

> > 
> > Are we sure that bunzip2 will always be found here? It might be better to 
> > use 
> > the system path instead of a hardcoded absolute path.
> > 
> 
> I cannot be sure it will always be there, of course ;-) The best
> solution is to use the system path for bunzip2, but also for dpkg and
> gunzip (a few lines above my patch in cache.py).

Please, just `sed -i s@/usr/bin/bunzip2@/bin/bunzip2@ cache.py`
and do the modification to use the system path instead of a hardcoded
absolute path outside bugreport #391869


Cheers
Geert Stappers

Attachment: signature.asc
Description: Digital signature

Reply via email to