Hello, (Thomas, please read on for a possible problem with the patch you committed in revision 901.)
(Note: this message is not entirely top-posted!) I am reiterating the request to preaprove the universalindentgui migration, but this time the 0.8.1-1.2 version. The new package can be downloaded from: http://users.alioth.debian.org/~eddyp-guest/upload/universalindentgui-0.8.1-1.2/ Mathew, Debian Release, the DSC is available at: http://users.alioth.debian.org/~eddyp-guest/upload/universalindentgui-0.8.1-1.2/universalindentgui_0.8.1-1.2.dsc The patch (relative to the last source in Debian Sid): http://users.alioth.debian.org/~eddyp-guest/upload/universalindentgui-0.8.1-1.2/universalindentgui_0.8.1-1--0.8.1-1.2.patch 2008/11/16 Nico Golde <[EMAIL PROTECTED]>: > Hi, > * Eddy Petri??or <[EMAIL PROTECTED]> [2008-11-13 12:20]: > [...] >> I have prepared a fix for 504726, but I am uneasy about C++ people looking >> at it (is strictly C). >> Also, I am aware this will, most likely not work on windows (but since this >> is a fix for us and >> symlinks are not possible under Windows, I guess is OK). > > I agree this might not be the best solution for upstream but > to get this quickly fixed for lenny this is ok. So unless Apropos to upstream's patch, I saw that Thomas made a fix for this issue in the upstream trunk in revision 901, but according to the QT FAQ (and from what I can understand) that fix is asking for a segfault. The part I am referring to is visible here: http://universalindentgui.svn.sourceforge.net/viewvc/universalindent/trunk/src/SettingsPaths.cpp?r1=893&r2=901&pathrev=901 and the relevant line I am referring to is: pathTemplate = QString(tempPath + "-XXXXXX").toAscii().data(); The QT FAQ says about QString to char* conversion: Note that it is necessary to store the bytearray before you call data() on it, a call like the following const char *c_str2 = str2.toLatin1().data(); will make the application crash as the QByteArray has not been stored and hence no longer exists http://trolltech.com/developer/faqs/faq.2007-01-30.9032238253 > someone comes up with an alternative now I suggest you > upload this NMU. The debdiff looks ok to me. -- Regards, EddyP ============================================= "Imagination is more important than knowledge" A.Einstein -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
