On Wed, 19 Nov 2008, Raphael Hertzog wrote:
> >  eval: [ $line =~ /^[0-9a-f]+ 
> > (.{7})\s+(\S+)\s+[0-9a-f]+\s+(\S+)?(?:(?:\s+$vis_re)?\s+(\S+))/ ]
> >  [  ]
> > 
> > I.e. no match. Instead by fixing it:
> > 
> >  eval: [ $line =~ /^[0-9a-f]+ 
> > (.{7})\s+(\S+)\s+[0-9a-f]+(?:\s+(\S+))?(?:\s+$vis_re)?\s+(\S+)/ ]
> >  [ '     D ', '*UND*', undef, undef, 'snprintf' ]
> 
> The analysis looks correct but I find the content of your $line a bit
> weird thus I'd like to see the full objump output. This way I can also add
> a non-regression test for the case at hand.

To be more precise, the case that currently fails are the one where
there's a single space between the alignment and the symbol name (with
no version and no visibility) because in that case it has to match this at
the end:
[0-9a-f]+\s+\s+(\S+)
And it can do that only if there's at least 2 spaces… your change
makes the first \s+ optional and thus solves the issue.

I'm about to commit the fix and the non-regression test.

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to