2008/11/25  <[EMAIL PROTECTED]>:
> Author: jhr-guest
> Date: Tue Nov 25 08:45:16 2008
> New Revision: 11872
>
> URL: http://svn.debian.org/wsvn/collab-maint/?sc=1&rev=11872
> Log:
> svn-buildpackage: Dropping support for linda (Closes: #502653)
>
> Modified:
>    deb-maint/svn-buildpackage/trunk/debian/changelog
>    deb-maint/svn-buildpackage/trunk/svn-buildpackage
>
> Modified: deb-maint/svn-buildpackage/trunk/debian/changelog
> URL: 
> http://svn.debian.org/wsvn/collab-maint/deb-maint/svn-buildpackage/trunk/debian/changelog?rev=11872&op=diff


==============================================================================
> --- deb-maint/svn-buildpackage/trunk/svn-buildpackage (original)
> +++ deb-maint/svn-buildpackage/trunk/svn-buildpackage Tue Nov 25 08:45:16 2008
> @@ -41,7 +41,6 @@
>   --svn-noautodch      Don't add a new Debian changelog entry when done
>  Post-build processing:
>   --svn-lintian        Run lintian after the build
> -  --svn-linda          Like --svn-lintian, run linda instead
>   --svn-move           Move package files to .. after successful build
>   --svn-move-to XYZ    Move package files to XYZ, implies --svn-move
>  Miscelaneous:
> @@ -66,7 +65,6 @@
>  my $opt_tag;
>  my $opt_only_tag;
>  my $opt_lintian;
> -my $opt_linda;
[..]
>    "svn-lintian"           => \$opt_lintian,
> -   "svn-linda"             => \$opt_linda,
>    "svn-no-links"          => \$opt_nolinks,


Wouldn't doing this make all builds fail for people that have
svn-linda in ~/.svn-buildpackage.conf ?

If that's the case, I guess is better to  have the option present
silently, warn that the option is ignored and do nothing with it, just
use it to show the warning.

Even better:
- remove the option from the help, keep it hidden
- warn (BIG FAT WARNING) before the code that previously ran linda
that the option is deprecated (no quitting, just a message)
- keep the rest of the code as it is, but test if linda exists, and
then run it if it exists

This could be useful for people that upgrade from etch to lenny, but
they kept linda around.

>         }
> -
> -        if($opt_linda) {
> -            withecho "linda", "$destdir/$chfile";
> -        }
>     }




-- 
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to