Jan Hauke Rahm a scris: > On Tue, Nov 25, 2008 at 03:38:52PM +0200, Eddy Petrișor wrote: >> This is not OK, since it breaks noninteractive builders. It should use >> some form of withEcho or something simillar in order to take into >> account the noninteractive option. > > True, my stupid mistake. Unfortunately withecho doesn't fit here. I'll > have another look at it to figure something out.
That's why I said "or something simillar" ;-) .
Maybe is time to add a prompt that takes into account the value of
>> This should be a warning, not a fatal error, thus...
>
> Well, I think user should have the chance to abort the process here (to
> not upgrade with source that's missing files), so a question seems
> reasonable for; don't you think?
>
>>> + prompt:
>>> + my $ans = <STDIN>;
>>> + if($ans !~ /^[yn]/i) {
>>> + print STDERR "The choices are:\n\tYes (y) which means
>>> aborting, or No (n) which means to NOT include those files.\n";
>> the default should be to go on with the ignored pattern, not to quit.
>
> Actually there is no default at all. At the moment you have to press y/Y
> or n/N, otherwise it will "retry". The question is (as above) if asking
> the user is more appropriate than just warning him/her.
>
>> Another solution would be to simply use "svn add --no-igore" with all
>> the files found in the filesystem.
>
> Hmm... I have to reread the code again... Why is that SVN::Client stuff
> in there and not just your suggested "svn add"? I can't see any
> advantage at the moment.
>
> Off topic: Why is that line
> return 1 if ($SDCommon::opt_ignoreerrors);
> in sub withechoNoPrompt? As far as I can see (and debug) that means that
> no command is executed when noninteractive and ignoreerrors are set. It
> just returns 1. That pretty much looks like a bug, doesn't it? (I'm
> becoming more cautious)
>
> Hauke
--
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein
signature.asc
Description: OpenPGP digital signature
