Bug#507204: lsb-pkgchk3: Missing include of stdlib.h and instances of printing a string variable directly

[James Westby]

Package: lsb-pkgchk3
Version: 3.2.1-1
Severity: normal
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

Here is a patch similar to bug 507201 for this package. Please
consider applying it.

Thanks,

James

diff -u lsb-pkgchk3-3.2.1/tests/misc/appchk/appchk.c lsb-pkgchk3-3.2.1/tests/misc/appchk/appchk.c
--- lsb-pkgchk3-3.2.1/tests/misc/appchk/appchk.c
+++ lsb-pkgchk3-3.2.1/tests/misc/appchk/appchk.c
@@ -306,7 +306,7 @@
             }
             break;
         case 'o':
-            snprintf(output_filename, TMP_STRING_SIZE, optarg);
+            snprintf(output_filename, TMP_STRING_SIZE, "%s", optarg);
             break;
         case 'j':
             do_journal = 1;
@@ -318,7 +318,7 @@
             do_missing_symbol = 1;
             break;
         case 'l':
-            snprintf(list_filename, TMP_STRING_SIZE, optarg);
+            snprintf(list_filename, TMP_STRING_SIZE, "%s", optarg);
             break;
         default:
             usage(argv[0]);
diff -u lsb-pkgchk3-3.2.1/tests/misc/pkgchk/pkgchk.c lsb-pkgchk3-3.2.1/tests/misc/pkgchk/pkgchk.c
--- lsb-pkgchk3-3.2.1/tests/misc/pkgchk/pkgchk.c
+++ lsb-pkgchk3-3.2.1/tests/misc/pkgchk/pkgchk.c
@@ -172,7 +172,7 @@
         printf("also checking symbols in module %s\n", optarg);
         break;
       case 'j':
-        snprintf(journal_filename, TMP_STRING_SIZE, optarg);
+        snprintf(journal_filename, TMP_STRING_SIZE, "%s", optarg);
         overrideJournalFilename = 1;
         break;
       case 'd':
only in patch2:
unchanged:
--- lsb-pkgchk3-3.2.1.orig/tests/misc/rpmchk/vals.c
+++ lsb-pkgchk3-3.2.1/tests/misc/rpmchk/vals.c
@@ -5,6 +5,7 @@
  *
  */
 #include "rpmchk.h"
+#include "stdlib.h"
 /*
  * This file contains some values which must match, and some places to
  * stick things which are discovered in one place, but used in another.