Bug#507213: netdiag: Doesn't specify a mode when calling open() with O_CREAT

[James Westby]

Package: netdiag
Version: 1.0-12
Severity: normal
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

Your package calls open() with the O_CREAT but without specifying a
mode. open(2) says that this isn't allowed. The attached patch adds
the mode argument to the call, please consider applying it.

Thanks,

James

diff -u netdiag-1.0/netwatch-1.0c/netwatch.c 
netdiag-1.0/netwatch-1.0c/netwatch.c
--- netdiag-1.0/netwatch-1.0c/netwatch.c
+++ netdiag-1.0/netwatch-1.0c/netwatch.c
@@ -2679,7 +2679,7 @@
          work->plog = open(nam,O_APPEND|O_WRONLY);
          if (work->plog<0)
          {
-            work->plog = open(nam,O_APPEND|O_CREAT|O_WRONLY);
+            work->plog = open(nam,O_APPEND|O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
             st = write(work->plog,&starttime,sizeof(starttime));
             st = write(work->plog,&simmagic,sizeof(simmagic));
          }