Greetings Giridhar,

On Tue, Dec 23, 2008 at 02:49:41PM +0530, Y Giridhar Appaji Nag wrote:

> > SO: if we need to consider this case, then the message for an upload
> > failure in step 1 needs to suggest *both* steps 2 and 3 before
> > re-trying the dput.
> 
> Certainly.  I tried to clarify this a bit but struggled to not make the
> diplayed message excessively long.  Does the following message that I
> just committed to git look OK?
> 
> Leaving existing %s on the server and continuing
> NOTE: This existing file may have been previously uploaded partially.
>         For official Debian upload queues, the dcut(1) utility can be
>         used to remove this file, and after an acknowledgement mail is
>         received in response to dcut, the upload can be re-initiated.

I have not looked at the sources in git, but the above leads me to
surmise that the message (including the long NOTE) is emitted during
upload each time a file is found to exist on the server.  So for a
package with 31 .debs, I might see this 30 times.

That could lead someone to assume that they need to use dcut to remove
each and every such file.  Whereas the truth is that they need remove
only the last file uploaded.  Right?

If so, maybe it would be better to display the NOTE at the end of a
failed upload instead.  Such a NOTE could be worded as follows.

  NOTE: Upload of file %s failed; this file may be trunctated or
  otherwise corrupt on the server.  For official Debian upload queues,
  the dcut(1) utility can be used to remove this file, and after an
  acknowledgement mail is received in response to dcut, the upload can
  be re-initiated.

What do you think?

Regards,
-Steve

Attachment: signature.asc
Description: Digital signature

Reply via email to