On Mon, Dec 29, 2008 at 01:31:32PM +0000, Robie Basak wrote: > Guido, > > On Sun, Dec 28, 2008 at 11:13:04PM +0100, Guido Günther wrote: > > > For users who use different email addresses for different packages (for > > > example: for personal and work use), use the details as specified by > > > git's user.name and user.email by default if they are available. > > > I like the idea and the patch looks fine, but what if somebody wants to > > use a different address for git commmits than for the Debian changelog. > > As soon as he sets the user.email/user.name via git config this isn't > > overridable anymore. Currently we use whatever dch picks up as user > > name/email address. > > I understand - with my current patch a user wouldn't be able to override > git's config setting so the commit email address will be forced to match. > > Would a further override in gbp.conf suffice? > > This would mean that: > > 1) For most maintainers, no action is required. > 2) For maintainers who need different addresses based on package, one > change to git's repository config is all that is needed. > 3) For maintainers who further need a different git commit address from > the changelog trailer, a further gbp.conf override is needed. > > Would this be acceptable? I was thinking of adding a simple:
# use author information from git: git-author=True/False to gbp.conf and corresponding --git-author/--no-git-author commandline options to git-dch. Making git-author default to False would keep existing behaviour. Does this make sense to you too? If so could you update your patch accordingly? Just have a look at how "sign-tags" is handled in git-buildpackage in 0.4.44 (or current git). Cheers, -- Guido -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
