> > > > I think no.1 is the more feasible option.
> > >
> > > So --clean should be the default? Or do you suggest to back out only
> > > the to-be-edited patch in dpep? How do we handle failures of doing so?
> >
> > Yeah, I think the feature of not cleaning the source dir before
> > copying is not working quite as intended.
>
> So we need to find out which value of the option is more useful. Since
> cleaning a package build dir might potentially destroy hours of
> compile time, I think that the current default is actually the safest.
From what I understand, current default will break
patch/unpatch if existing patch is edited.
We will need to be able to at least 'unpatch'
when currently applied patch is going to be edited.
When 'unpatch' is done, we don't really know if
clean will ever succeed again, so we will need to
clean before unpatching.
Thus, --clean is required for cases where existing
patch (when you find something matching in debian/patched/XXX )
Thoughts?
regards,
junichi