tags 293335 + patch pending
thanks
* Martin Michlmayr <[EMAIL PROTECTED]> [2005-02-02 15:53]:
> --help shows
>
> usage: jack [option]...
> --bitrate, -b target bitrate in kbit/s [160] +
> --debug show debug information [0]
> --query, -q do freedb query when all is done
> --query-if-needed query freedb when starting if not queried already [0]
> --query-now, -Q do freedb query when starting
> --rename, -R rename according to freedb file, eg. after editing it
> --vbr, -v generate variable bitrate files [1] +
>
> It seems strange that --bitrate is shown but --quality is not even
> though --vbr is on. Maybe --quality could be added when --vbr is on?
* Michael Banck <[EMAIL PROTECTED]> [2005-03-25 23:11]:
> Indeed, --quality seems more appropriate than --bitrate and --vbr I
> guess. Arne, what do you think?
Actually, the solution is much easier than what I initially proposed:
given that --vbr is on by default, --quality should be shown in the
short help instead of --bitrate, and both should be shown with
--longhelp.
Here's a patch:
diff -urN jack-3.1.1~/jack_config.py jack-3.1.1/jack_config.py
--- jack-3.1.1~/jack_config.py 2005-06-19 20:10:52.764878208 +0100
+++ jack-3.1.1/jack_config.py 2005-06-19 20:11:33.207729960 +0100
@@ -80,7 +80,6 @@
'bitrate': {
'type': types.IntType,
'val': 160,
- 'help': 1,
'doc': "default bitrate",
'usage': "target bitrate in kbit/s",
'short': 'b',
@@ -98,6 +97,7 @@
'vbr_quality': {
'type': types.FloatType,
'val': 6,
+ 'help': 1,
'usage': "vbr encoding quality. -1 is lowest, 10 highest.",
'long': 'quality',
},
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
