On Sun, Jan 18, 2009 at 06:36:52PM +0100, Thorsten Alteholz wrote:
> Hi,
>
> this is a patch to fix this issue. No logfile will be created by default  
> anymore. If you use the new option "-logfile" a file called log.txt will  
> be created. If you use the new option like "-logfile name-of-file.log" a  
> file called name-of-file.log will be created.

The patch looks OK save for this:

-       fclose(logfile);
-       exit(status);
+       if (logfile) {
+               fclose(logfile);
+               exit(status);
+       }
 }


it should be this intead:

-       fclose(logfile);
+       if (logfile) {
+               fclose(logfile);
+       }
       exit(status);
 }

Because the exit status should be preserved even if no logfile is generated.

I'm going to apply it and provide a new openuniverse package with this fix
soon.

Regards

Javier

Attachment: signature.asc
Description: Digital signature

Reply via email to