On Mon, Feb 02, 2009 at 04:21:18PM +0100, Joachim Breitner wrote: >Hi Bernhard, > >Am Montag, den 02.02.2009, 16:13 +0100 schrieb Bernhard Reutner-Fischer: >> The debian package (-9 at the time of this writing) still eats too much CPU >> for displaying clock and mixer. >> >> I'm attaching a small series of (IMHO) improvements that i had to make >> during cursory initial testing. >> Please consider adding this series to the debian patchset. >> Who is maintaining this package upstream? > >thanks for your work so far. Upstream author is Heron Ordoñez Guillén, >who you have CC’ed. > >Heron: Are you still working on osdsh? Will you look at Bernhard’s >patches, include them in the official package and make a new release? > >I’d rather not add too many patches to the Debian side, as that would >basically mean taking over upstream maintenance, which I’m do not want. >Bernhard, are you interested in taking over some responsibility here?
I'm not sure what you mean me to do, what kind of responsibility do you have in mind? I'm not a dd and want to avoid to go into nmu land (although i've pondered NMUs for a handful of packages in the past. Completely different story though and highly OT). I definitely do not want to take over osdsh's upstream, if you mean that :) That said, upstream should have a look at make clean && make CFLAGS="-O3 -W -Wall -pedantic -D_FORTIFY_SOURCE=2" i'd suggest. This doesn't turn up too much but would be nice to have fixed mid-term. Also, osdctl and osdsh use much more static buffers than IMO needed: $ size /opt/osdsh/bin/* text data bss dec hex filename 4097 304 16 4417 1141 /opt/osdsh/bin/osdctl 9409 456 16924 26789 68a5 /opt/osdsh/bin/osdsh $ ls -ln /opt/osdsh/bin/* -rwxr-xr-x 1 1000 1000 6184 2009-02-02 16:47 /opt/osdsh/bin/osdctl -rwxr-xr-x 1 1000 1000 11728 2009-02-02 16:47 /opt/osdsh/bin/osdsh and the binaries from the debian package, for reference: $ size /usr/bin/osd* text data bss dec hex filename 5262 324 12 5598 15de /usr/bin/osdctl 13641 468 29280 43389 a97d /usr/bin/osdsh $ ls -ln /usr/bin/osd* -rwxr-xr-x 1 0 0 7132 2007-06-17 11:01 /usr/bin/osdctl -rwxr-xr-x 1 0 0 15664 2007-06-17 11:01 /usr/bin/osdsh >> I am not able to 'osmsh -s fooöäü߀µ¢bar', i.e. display "umlaut" chars >> via xosd_display, is this a known bug? > >I can reproduce it here. s/osmsh/osdctl/;# i ment, sorry: opensm != osdctl; fingers playing tricks on me Can you try to pinpoint this and/or file a bug, please? Many thanks in advance! cheers, Bernhard -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
