Package: fai-client
Version: 3.2.17+experimental14
Severity: normal

In save_log_remote_shell, we have:

    $remotesh -l $LOGUSER $LOGSERVER " \
       mkdir -p $thislog ;\
       cd $HOSTNAME ;\

which only works if $thislog = ~$LOGUSER/$HOSTNAME, which isn't even remotely 
true in my case, since I set $LOGREMOTEDIR
explicitely.

Here's a patch.

--- /srv/fai/nfsroot-i386/live/filesystem.dir/usr/lib/fai/fai-savelog   
2009-01-12 04:13:18.000000000 -0800
+++ /tmp/fai-savelog    2009-02-15 00:56:46.000000000 -0800
@@ -58,18 +58,21 @@
 # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 save_log_remote_shell() {

-    local thislog
+    local thislogdir
     if [ -n "$LOGREMOTEDIR" ];then
-       thislog=$LOGREMOTEDIR/$HOSTNAME/$FAI_ACTION-$fai_rundate
+       thislogdir=$LOGREMOTEDIR/$HOSTNAME/
     else
-       thislog=$HOSTNAME/$FAI_ACTION-$fai_rundate
+       thislogdir=$HOSTNAME/
     fi

+    local thislog
+    thislog=$thislogdir/$FAI_ACTION-$fai_rundate
+
     echo "Save log files via $remotesh to $logu...@$logserver:$thislog"
     find $LOGDIR -size 0 -type f -exec rm {} \;
     $remotesh -l $LOGUSER $LOGSERVER " \
        mkdir -p $thislog ;\
-       cd $HOSTNAME ;\
+       cd $thislogdir ;\
        rm -f last-$FAI_ACTION ;\
        ln -snf $FAI_ACTION-$fai_rundate last-$FAI_ACTION ;\
        ln -snf $FAI_ACTION-$fai_rundate last"


-- System Information:
Debian Release: 5.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24.2-ls4 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages fai-client depends on:
ii  file                       4.26-1        Determines file type using "magic"
ii  libapt-pkg-perl            0.1.22+b1     Perl interface to libapt-pkg
ii  liblinux-lvm-perl          0.14-1        module to access LVM status inform
ii  libparse-recdescent-perl   1.95.1+dfsg-3 generates recursive-descent parser
ii  perl                       5.10.0-19     Larry Wall's Practical Extraction 

Versions of packages fai-client recommends:
ii  cfengine2                     2.2.8-1    Tool for configuring and maintaini
ii  debconf-utils                 1.5.24     debconf utilities

Versions of packages fai-client suggests:
pn  cryptsetup                   <none>      (no description available)
ii  dmsetup                      2:1.02.27-4 The Linux Kernel Device Mapper use
ii  logtail                      1.2.69      Print log file lines that have not
pn  ntfsprogs                    <none>      (no description available)

-- no debconf information



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to