On Wed, 25 Feb 2009, Petr Pudlak (Debian) wrote:

dget -u http://petr.pudlak.name/deb/eprover_1.0.004-1.dsc

I had a short look onto your work and would like to give some
comments.  At first you obviousely did a good job to create a
lintian clean package of a complex software!  Considering that
you even provided man pages for binaries in /usr/bin shows
that you made some effort.  Especially if it is your first
package that's very good.

Some (nitpicking!!) idea: Have you considered to move the
examples into a separate package.  These are not really of
a size which should be separated I just want to know whether
you know about the option to separate architeture independant
files into a separate package exspecially of the package might
work without these files.  If you confirm that you know this
option but decided against it intentionally because the examples
are a very impornat part of the package it is perfectly fine
for me.

Regarding team maintenance: I've seen that you have patched
several files and did not used a patch system (like quilt or
dpatch).  Doing so seems to make Git the better choice for
a Version Control System because we have the policy to not
commit the upstream source to SVN and use patches instead.
The Git workflow (which I'm not very comfortable with) seems
to relay on commiting the whole source and patch the files
accordingly.  So the question is: Have you made up your mind
about commiting eprover to the Debian Science reporitory?
While this is not required to find a sponsor I would like
to recommend this once more.  In this case you should add
Vcs-Git fields to debian/control.  Just take a look at other
packages in the Vcs and also see how Maintainer and Uploaders
are handled there.

I would love if someone else - preferably with better knowledge
of this program would be check the package and perhaps do the
actual sponsoring.  If nobody will step up I can upload the
package (but not before Monday next week).

Kind regards and thanks for your work

      Andreas.

--
http://fam-tille.de



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to