Package: buildbot
Version: 0.7.8-1
Severity: normal
Tags: patch

(This bug has a ticket http://buildbot.net/trac/ticket/430)

This 

        cvs up -dP -r [branch] -D [timestamp] [simple_dir]

doesn't work for me absolutely. In CVS FAQ i saw some (undocumented?) trick for 
such a task: 

        cvs up -dP -r [branch]:[timestamp] [simple_dir]

commented by audience as "dreaming" because it doesn't work either. 

The 'alwaysUseLatest = True' does a little help since it affects only when 
there is no autodetected source revision: 

        # if revision is None, use the latest sources (-rHEAD)
        revision = s.revision
        if not revision and not self.alwaysUseLatest:
            revision = self.computeSourceRevision(s.changes)

But I can hardly imagine such circumstances. 

I made a quick workaround for this CVS bug but cannot be sure is this a best 
way. 

--- /usr/share/pyshared/buildbot/slave/commands.py~     2008-07-25 
03:36:25.000000000 +0400
+++ /usr/share/pyshared/buildbot/slave/commands.py      2009-02-19 
17:51:06.000000000 +0300
@@ -1472,7 +1472,7 @@
         command = [self.vcexe, '-z3'] + self.global_options + ['update', '-dP']
         if self.branch:
             command += ['-r', self.branch]
-        if self.revision:
+        elif self.revision:
             command += ['-D', self.revision]
         c = ShellCommand(self.builder, command, d,
                          sendRC=False, timeout=self.timeout)
@@ -1490,7 +1490,7 @@
                    [verb, '-d', self.srcdir])
         if self.branch:
             command += ['-r', self.branch]
-        if self.revision:
+        elif self.revision:
             command += ['-D', self.revision]
         command += [self.cvsmodule]
         c = ShellCommand(self.builder, command, d,

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.24-etchnhalf.1-686
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)

Versions of packages buildbot depends on:
ii  adduser                       3.102      Add and remove users and groups
ii  python                        2.4.4-2    An interactive high-level object-o
ii  python-central                0.6.8      register and build utility for Pyt
ii  python-twisted-core           2.4.0-3    Event-based framework for internet
ii  python-twisted-mail           0.3.0-1    An SMTP, IMAP and POP protocol imp
ii  python-twisted-web            0.6.0-1    An HTTP protocol implementation to
ii  python-twisted-words          0.4.0-2.1  Chat and Instant Messaging

buildbot recommends no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to