-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 [sent again, to bugreport this time]
On Fri, Feb 27, 2009 at 06:05:53PM +0100, martin f krafft wrote: >also sprach Jonas Smedegaard <d...@jones.dk> [2009.02.27.1743 +0100]: >> Please consider shipping the attached CDBS snippet with topgit: >> >> 1) install it as /usr/share/cdbs/1/topgit.mk > >Thanks for the bug report! > >I'll cut you a deal: I'll do this if you write me a brief >README.quilt for inclusion, which explains how to use topgit and >cdbs, ideally with an example and in a way that allows people to >figure out what happens when and why. I would find this very useful. Something like this: git.debian.org/git/collab-maint/cdbs-skel ? >> 2) have the binary "topgit" package suggest cdbs > >I will have to think about that. TopGit is not about Debian >packaging, but cdbs is. I am not sure I like this relation, but >I will think about it. ...which is the reason I propose to _suggest_ (not recommend): Something that makes more use of your package, without being relevant for most users. (written from the top of my head - actual official defined purpose of "suggests" is most probably slightly differently worded) >> Including my proposed snippet does not exactly solve this bug, but it >> turns it into a less severe one: >> >> CDBS use majuscles (capital letters) for variables allowed to be changed >> and minuscles for "internal" variables (i.e. possibly shared across >> snippets but not for the packages to redefine). >> >> The current need for the topgit.mk snippet to declare PATCHES_DIR is >> confusing as it might wrongly be seen as an invitation for overriding. > >Hm. Stefano analysed the situation by saying: > > However, CDBS users do not reqly on quilt.make, but rather on > /usr/share/cdbs/1/rules/patchsys-quilt.mk , which neither include > quilt.make nor provide the same "API" by the means of > QUILT_PATCH_DIR. > >I am a little uninclined to address this in TopGit. Why doesn't >patchsys-quilt emulate the "API" properly? patchsys-quilt.mk is provided by quilt - just as I propose adding topgit.mk to topgit :-) ...so I guess you should forward that very relevant question to quilt maintainers. Perhaps they had someone external to them hand them a script - just as I do for you now. >Also, cdbs uses majuscles for editable stuff, and miniscules for >internal stuff? That's *exactly* the opposite from how I learnt to >code (though not necessarily how I code these days), which is to use >capitals for constants and lowercase for everything else. The point >is that adopting cdbs style on this might just cause a conflict >elsewhere. Ahem, problem is my bad use of terms here. All capitalized variables are, I believe, meant to be static. But they can be (re)defined by the package maintainer. It might be that the location of patches can be redefined, but redefining topgit patch location independently from quilt patch location makes no sense - and might break thing. Does that make sense, or should I come up with an concrete example? >Instead, I think this might best be addressed with a comment before >the PATCHES_DIR variable, which explains what it's for and when it >can be changed and what the user has to consider. Agreed? Uh, why not simply use a single variable name across snippets? >> ...you should probably have the package suggest quilt as well, but >> that really is a separate issue - and I am too eager to play some >> more with TopGit to file a separate bugreport about it :-P > >Consider that done with commit 6d8cb97. > >http://git.debian.org/?p=collab-maint/topgit.git;a=commitdiff;h=6d8cb9730c6ec32fd56d8b0eb254ac0f835ec475 Good. - Jonas - -- * Jonas Smedegaard - idealist og Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkmpO8QACgkQn7DbMsAkQLhRxgCeJvwd2E1uFY8NOQKil5h/ls+B BiMAn3j/2Io4CyXxfuJLS1xoMdtdu81I =05Pa -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
