Hi, On Saturday, 7. March 2009, Steve Langasek wrote: > tags 518657 -patch > thanks > > On Sat, Mar 07, 2009 at 07:25:31PM +0100, Peter Marschall wrote: > > --- debian/slapd.scripts-common > > +++ debian/slapd.scripts-common 2009-03-07 14:37:36.000000000 +0100 > > @@ -632,7 +632,7 @@ > > # For the domain really.argh.org we create the basedn > > # dc=really,dc=argh,dc=org with the dc entry dc: really > > db_get slapd/domain > > - local basedn="dc=`echo $RET | sed 's/^\.//; s/\./,dc=/g'`" > > + basedn="dc=`echo $RET | sed 's/^\.//; s/\./,dc=/g'`" > > dc="`echo $RET | sed 's/^\.//; s/\..*$//'`" > > > > db_get slapd/backend > > This patch is wrong and should not be applied. Variables used in functions > should be locally scoped, they just need to be declared in the manner > supported by policy.
I'm sorry, you're wrong here. The variable has been declared local a few lines before. If you want to, you may look at the extended patch (created with -u -U 7) Regards Peter -- Peter Marschall [email protected]
--- debian/slapd.scripts-common +++ debian/slapd.scripts-common 2009-03-07 20:59:19.000000000 +0100 @@ -628,15 +628,15 @@ # Create a new configuration and directory local basedn dc backend # For the domain really.argh.org we create the basedn # dc=really,dc=argh,dc=org with the dc entry dc: really db_get slapd/domain - local basedn="dc=`echo $RET | sed 's/^\.//; s/\./,dc=/g'`" + basedn="dc=`echo $RET | sed 's/^\.//; s/\./,dc=/g'`" dc="`echo $RET | sed 's/^\.//; s/\..*$//'`" db_get slapd/backend backend="`echo $RET|tr A-Z a-z`" # Looks like the following code is not needed as slapd is unconfigured # first and stopped at that time. So no need to stop slapd at all here.
