At Wed, 13 May 2009 01:51:05 +0200,
Christoph Anton Mitterer wrote:
> 
> Package: dsh
> Severity: minor
> 
> Hi.
> 
> 1) "An utility to effectively do a for a in $(seq 1 10); do rsh $a  
> command; done in bourne shell." in the beginning is a little bit,..  
> well... I mean it's clear what you want to tell the reader,.. but rsh  
> 1 command would be strange,... an apart from that dsh does not only  
> support rsh ;)

not quite sure I take that.
 
> 2)
> "From  version  0.21.4,  it  is possible to specify in the format of  
> usern...@machinename,usern...@machinename,usern...@machinename so
>                that multiple hosts can be specified with  
> comma-delimited values."
> As "this" is already the manpage in a version above 0.21.4, you could  
> remove that note IMHO, and add the syntax with username@ to the  
> beginning "--machine | -m [machinename[,machinename]*]"

NAK

> 
> 3) For perfection, it should be mentioned how the format for --group  
> files and machine.list ist,.. (the same as you write in the  
> description --file, I assume)... One could even make a separate  
> section for the syntax.

I don't quite get you??

> 
> 4)  --remoteshell
> Is there a default if none is specified and multiple are available? Or  
> is it (what I'd personally like the most) simply necessary to give  
> this somehow?

Default is 'rsh', maybe that should be documented.
Patch welcome.


> 5) In the files section you always write "$(HOME)",.. is this valid  
> shell code? I think it should be either ~/. , or ${HOME}/. or $HOME/.


It's a valid Makefile construct, not quite sure if it should be a
valid shell code, I think the intention is clear.





-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to