#include <hallo.h> * Alexander Inyukhin [Mon, May 25 2009, 01:30:38AM]:
> I have noticed, that acng eats all available to a process > virtual memory after some days of work, and it starts > to return 503 to all requests. > It spawns a lot of threads and keeps them running. How many exactly? (ps -L ...) What exactly is in the HTTP status line (after 503)? > The reason of this behavior is race condition while counting spare threads. > Variable nSpareThreads must change under mutually exclusive lock, > but in the function ThreadAction it is guarded with reLock function, > which allows all workers to enter this critical section simultaneously. > > Due to this nSpareThreads is increased slower, than it should, and it allows > threads to leak. Nice idea, but I don't think so. Reason: both code positions (decrementing and incrementing) are covered by the mutex which is inside of the global object "cond" (to which lockguard helpers are connected in both cases). Further, reaching thread limit would have different symptoms (not throwing 503... just grep for "503", it's not used in conserver.cc at all). However, your problem might be somehow connected to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=529744 . That problem looks like many downloader objects not being released (according to pipe/socket ratio) which might also be caused by hanging user connection threads. And receiving two heavy bug reports within one week after no such problem has been reported for months, that's very suspicious. I just don't have a good idea yet. Version 0.3.12 was released few minutes ago and should appear on incoming.debian.org now. It adds proper handling for EINTR on close(). Please take that one for further tests. If the problem disappears -> great, if not: please provide thread count and status of file handles (lsof) and last lines of apt-cacher.err file. И в любом случае спасибо :-) Благодарю, Eduard. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
