reopen 451222 thanks I was having a really good day until I got this:
> > As part of the long term mass bug filing for cross building support, > > (http://lists.debian.org/debian-devel/2007/11/msg00116.html), I've > > prepared this patch for debian/rules. > > As I said before your patch is wrong and I am not inclined to argue > the point anymore, so I am closing this bug. What is the point of closing a bug without a fix? The package will not cross-build and the change makes no difference to the Debian package. > There is no need to > NMU libjpeg to include this broken patch. Well I'll have to NMU the package to fix the cross-build. It can't be left as-is. The patch is not wrong - it works just fine and it is completely insulated from the Debian builds. > I apologize not to have done that sooner. That doesn't help me and Emdebian. The package still fails to cross-build outside your emulator tests. The libtool handling used in the Debian package prevents cross-building, the Emdebian patch fixes it, simple as that. > I do not understand how do that work given than the original libtool > script is not able to build the package. During the cross-build, supporting scripts provide a replacement libtool setup that has none of the problems you've described. > Did you check this patch actually allow libjpeg to be cross-compiled ? Of course, all patches are only created after a successful cross-build and this has also been tested on real Emdebian devices. Yes. It was released as part of Emdebian Crush 1.0 based on Debian 5.0. > If yes, how did you proceed ? Applied the patch, cross-built the package with emdebian-tools and uploaded it to Emdebian Crush. Installed it, works fine. The patch has been tested and the cross-built package is just fine. Emulation is simply not acceptable. The package can cross-build just fine with the emdebian-tools setup. It doesn't even need the workarounds that some other packages need for old, broken, libtools. rpath is not an issue for Emdebian - I don't care what happens with it, it simply doesn't matter within the context of Emdebian installations. I'm attaching the latest version of the Emdebian Crush patch. I still intend to NMU using the attached patch. -- Neil Williams ============= http://www.data-freedom.org/ http://www.nosoftwarepatents.com/ http://www.linux.codehelp.co.uk/
--- libjpeg6b.old/debian/rules Mon May 25 19:48:43 2009 +++ /opt/emdebian/trunk/l/libjpeg6b/trunk/libjpeg6b-6b/debian/rules Mon May 25 19:48:43 2009 @@ -7,6 +7,15 @@ export DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE) export DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE) +ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE)) +CROSS=CC=$(DEB_HOST_GNU_TYPE)-gcc +confflags= --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE) $(CROSS) +WRAP_LIBTOOL= +else +confflags= --build $(DEB_BUILD_GNU_TYPE) +WRAP_LIBTOOL=printf '#!/bin/sh\nexec libtool "$$@"\n' >libtool +endif + include debian/patch.mk export CFLAGS=-D_REENTRANT -g -Wall @@ -16,6 +25,12 @@ CFLAGS += -O2 endif +ifneq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS))) +CHECK= +else +CHECK=$(MAKE) test +endif + #export DH_VERBOSE=1 build: build-stamp @@ -23,11 +38,11 @@ dh_testdir ./configure --prefix=/usr --mandir=usr/share/man \ --enable-static --enable-shared --enable-maxmem=1024 \ - --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE) - printf '#!/bin/sh\nexec libtool "$$@"\n' >libtool - $(MAKE) - $(MAKE) test - $(MAKE) -C debian/extra + $(confflags) + $(WRAP_LIBTOOL) + $(MAKE) $(CROSS) + $(CHECK) + $(MAKE) -C debian/extra $(CROSS) touch build-stamp
pgpYZIW1LPJn6.pgp
Description: PGP signature
