Package: quilt
Version: 0.46-7
Severity: wishlist
Tags: patch
The patch target in /usr/share/quilt/quilt.make contains a comment, in which
is stated that quilt exiting with a status of 2 is not an error.
As a result, when building any package which uses quilt, the word "error"
pops up on the screen.
Like many programmers, I have acquired the habit of scanning the compilation
output and to promptly recognize words like "error" or "warning". Because of
this, every time I build a quilt-using package, for a split second I get the
impression the build is failing, which is not actually the case.
I have created three suitable patches: the first one is the one guaranteed
to be more portable, the third one is my favourite. I have no strong
feelings about the second one.
Pick the one you like most.
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'stable'), (80, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.29-1-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages quilt depends on:
ii bzip2 1.0.5-1 high-quality block-sorting file co
ii diffstat 1.47-1 produces graph of changes introduc
ii gettext 0.17-6 GNU Internationalization utilities
ii patch 2.5.9-5 Apply a diff file to an original
quilt recommends no packages.
Versions of packages quilt suggests:
pn graphviz <none> (no description available)
pn procmail <none> (no description available)
-- no debconf information
--- quilt.make.orig 2009-05-30 17:39:01.000000000 +0200
+++ quilt.make 2009-05-30 17:40:07.000000000 +0200
@@ -13,8 +13,6 @@
patch: $(QUILT_STAMPFN)
$(QUILT_STAMPFN):
- # quilt exits with 2 as return when there was nothing to do.
- # That's not an error here (but it's useful to break loops in crude
scripts)
QUILT_PATCHES=$(QUILT_PATCH_DIR) quilt --quiltrc /dev/null push -a ||
test $$? = 2
touch $(QUILT_STAMPFN)
--- quilt.make.orig 2009-05-30 17:39:01.000000000 +0200
+++ quilt.make 2009-05-30 17:41:58.000000000 +0200
@@ -13,8 +13,8 @@
patch: $(QUILT_STAMPFN)
$(QUILT_STAMPFN):
- # quilt exits with 2 as return when there was nothing to do.
- # That's not an error here (but it's useful to break loops in crude
scripts)
+# quilt exits with 2 as return when there was nothing to do.
+# That's not an error here (but it's useful to break loops in crude scripts)
QUILT_PATCHES=$(QUILT_PATCH_DIR) quilt --quiltrc /dev/null push -a ||
test $$? = 2
touch $(QUILT_STAMPFN)
--- quilt.make.orig 2009-05-30 17:39:01.000000000 +0200
+++ quilt.make 2009-05-30 17:43:10.000000000 +0200
@@ -13,8 +13,8 @@
patch: $(QUILT_STAMPFN)
$(QUILT_STAMPFN):
- # quilt exits with 2 as return when there was nothing to do.
- # That's not an error here (but it's useful to break loops in crude
scripts)
+ @# quilt exits with 2 as return when there was nothing to do.
+ @# That's not an error here (but it's useful to break loops in crude
scripts)
QUILT_PATCHES=$(QUILT_PATCH_DIR) quilt --quiltrc /dev/null push -a ||
test $$? = 2
touch $(QUILT_STAMPFN)
