On Tue, Jun 02, 2009 at 11:40:24AM -0500, Jamie Strandboge wrote: > Thank you. As mentioned in out initial correspondence, I was out of town > the last two weeks and had limited opportunity to work on ufw. That > said, I am back now and ready to comment. Hopefully my comments will > fall within the time-frame for these changes. Your work on this is much > appreciated.
That's fine; I knew you were AFK so I've held fire until now to make sure I got your views considered :) > > - To start or stop ufw without rebooting, please use '/etc/init.d/ufw > > start' or > > - '/etc/init.d/ufw stop'. > > +_Description: Start ufw automatically? > > + If you choose this option, the rules you are about to set will take > > immediate > > + effect, and will be enabled during startup so that this host is protected > > + as early as possible. > > + . > > + Alternatively, you may start ufw manually but this host > > + will not be protected until you do so. > > > > Two things regarding this. 'immediate' is not accurate because postinst > does not start ufw due to potential iptables failures (eg the installer > kernel has different modules available). We ran into this in earlier > versions in Ubuntu. The 'will' in the original description was meant to > convey that ufw will be enabled some time in the future and will be > active on reboot. I propose this line instead: + If you choose this option, the rules you are about to set + will be enabled during system startup so that this host is protected + as early as possible. Christian: do you think this is a reasonable change without going round an RFR? > Also, while this is indeed a boolean, due to limitations in the gtk > debconf backend, it was deemed that the original wording worked best > with the gtk checkbox. See http://launchpad.net/bugs/344971 for details. > If you feel that the Description here is better considering all > contexts, I am fine with making the change, but I wanted to point our > the gtk debconf deficiency. As long as you're happy with Christian's rationale for this one, I'll leave it as it is (I wasn't involved with the Installer discussions so my experience is limited here). -- Jonathan Wiltshire PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3 A903 CA6B EA3E DB80 0B52
signature.asc
Description: Digital signature
