Package: subversion-tools
Version: 1.5.1dfsg1-2
Severity: normal

commit-email.pl in lenny (subversion-tools 1.5.1dfsg1-2) adds the
non-header "From <whatever>" in front of real e-mail headers when using
/usr/sbin/sendmail.  It's only supposed to do this when printing to
stdout in mbox-like mode.

This breaks my commit mails with ssmtp providing /usr/sbin/sendmail.
Other MTAs might be more forgiving about this.

Resulting mails look then like this:
| Return-Path: oftc-commits-boun...@lists.oftc.net
| X-Original-To: oftc-cvs-commits=lists.oftc....@lists.palfrader.org
| Delivered-To: wea...@anguilla.debian.or.at
| Received: from fusion.oftc.net (fusion.oftc.net [72.3.249.93])
|         (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
|         (Client CN "fusion.oftc.net", Issuer "servers.ca.oftc.net" (not 
verified))
|         by anguilla.debian.or.at (Postfix) with ESMTP id 6E31110FA77
|         for <oftc-cvs-commits=lists.oftc....@lists.palfrader.org>; Mon,  1 
Jun 2009 02:12:16 +0200 (CEST)
| Received: from fusion.oftc.net (localhost [127.0.0.1])
|         by fusion.oftc.net (Postfix) with ESMTP id 22EB255409D;
|         Mon,  1 Jun 2009 00:12:15 +0000 (UTC)
| Received: from mole.oftc.net (unknown [127.0.6.1])
|         by fusion.oftc.net (Postfix) with SMTP id 42AE2554060
|         for <oftc-comm...@lists.oftc.net>; Sat, 30 May 2009 17:59:22 +0000 
(UTC)
| Received: by mole.oftc.net (sSMTP sendmail emulation);
|         Sat, 30 May 2009 17:59:22 +0000
| From: www-data <www-d...@mole.oftc.net>
| Message-Id: <20090530175922.42ae2554...@fusion.oftc.net>
| Local-Date: Sat, 30 May 2009 19:59:22 +0200
| Date: Sat, 30 May 2009 17:59:22 +0000 (UTC)
| To: undisclosed-recipients: ;
| X-Mailman-Approved-At: Mon, 01 Jun 2009 00:12:08 +0000
| X-BeenThere: oftc-comm...@lists.oftc.net
| X-Mailman-Version: 2.1.11
| Precedence: list
| List-Id: commit mails for OFTC source projects <oftc-commits.lists.oftc.net>
| List-Unsubscribe: 
<https://lists.oftc.net/cgi-bin/mailman/options/oftc-commits>,
|         <mailto:oftc-commits-requ...@lists.oftc.net?subject=unsubscribe>
| List-Archive: <http://lists.oftc.net/pipermail/oftc-commits>
| List-Post: <mailto:oftc-comm...@lists.oftc.net>
| List-Help: <mailto:oftc-commits-requ...@lists.oftc.net?subject=help>
| List-Subscribe: 
<https://lists.oftc.net/cgi-bin/mailman/listinfo/oftc-commits>,
|         <mailto:oftc-commits-requ...@lists.oftc.net?subject=subscribe>
| MIME-Version: 1.0
| Content-Type: text/plain; charset="us-ascii"
| Content-Transfer-Encoding: 7bit
| Sender: oftc-commits-boun...@lists.oftc.net
| Errors-To: oftc-commits-boun...@lists.oftc.net
| 
| From wea...@oftc.net Sat May 30 17:59:22 2009
| Date: Sat, 30 May 2009 17:59:22 +0000
| To: oftc-comm...@lists.oftc.net
| Subject: [oftc-tools] r316 - in trunk/oftcdns: . oftcdns
| Reply-to: oftc-st...@lists.oftc.net
| Content-Type: text/plain; charset=UTF-8
| Content-Transfer-Encoding: 8bit
| 
| Author: weasel
| Date: 2009-05-30 17:59:21 +0000 (Sat, 30 May 2009)
| New Revision: 316
| 
| Modified:
|    trunk/oftcdns/acinclude.m4
..


Note that the headers that should end up in the mail prober instead end
up in the body.

Please try to fix this for the next lenny point release:

--- /usr/share/subversion/hook-scripts/commit-email.pl  2009-06-12 
16:06:43.000000000 +0000
+++ /usr/local/bin/commit-email.pl      2009-06-12 16:06:55.000000000 +0000
@@ -557,7 +557,7 @@
 
     my @head;
     my $formatted_date;
-    if (defined $stdout)
+    if ($stdout)
       {
         $formatted_date = strftime('%a %b %e %X %Y', localtime());
         push(@head, "From $mail_from $formatted_date\n");


Cheers,
weasel



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to