Charles Plessy wrote:
include /usr/share/R/debian/r-cran.mk

This will then include /usr/share/cdbs/1/rules/debhelper.mk, but
since lintian does not see it in debian/rules, it throws an error of
the ‘build-depends-without-arch-dep’ type for debhelper, cdbs, and
r-base-dev (that provides /usr/share/R/debian/r-cran.mk).

Because it implies three dependancies that can be in any order, I did
not figure out how to add a proper entry in our @GLOBAL_CLEAN_DEPENDS
to solve that problem…

Just add all three. :-)

diff --git a/checks/fields b/checks/fields
index 1438d8e..20af81a 100644
--- a/checks/fields
+++ b/checks/fields
@@ -121,15 +121,18 @@ our $PYTHON_DEPEND = 'python | python-dev | python-all | python-all-dev | '
our @GLOBAL_CLEAN_DEPENDS = (
       [ ant => qr'^include\s*/usr/share/cdbs/1/rules/ant\.mk' ],
       [ cdbs => qr'^include\s+/usr/share/cdbs/' ],
+       [ cdbs => qr'^include\s+/usr/share/R/debian/r-cran\.mk' ],
       [ dbs => qr'^include\s+/usr/share/dbs/' ],
[ 'dh-make-php' => qr'^include\s+/usr/share/cdbs/1/class/pear\.mk' ], [ debhelper => qr'^include\s+/usr/share/cdbs/1/rules/debhelper\.mk' ],
+       [ debhelper => qr'^include\s+/usr/share/R/debian/r-cran\.mk' ],
       [ dpatch => qr'^include\s+/usr/share/cdbs/1/rules/dpatch\.mk' ],
       [ 'gnome-pkg-tools' => qr'^include\s+/usr/share/gnome-pkg-tools/' ],
[ quilt => qr'^include\s+/usr/share/cdbs/1/rules/patchsys-quilt\.mk' ],
       [ dpatch => qr'^include\s+/usr/share/dpatch/' ],
       [ quilt => qr'^include\s+/usr/share/quilt/' ],
[ 'ruby-pkg-tools' => qr'^include\s+/usr/share/ruby-pkg-tools/1/class/' ],
+       [ 'r-base-dev' => qr'^include\s+/usr/share/R/debian/r-cran\.mk' ],
[ $PYTHON_DEPEND => qr'/usr/share/cdbs/1/class/python-distutils\.mk', 'missing-python-build-dependency' ],
);

$ lintian -I -E --pedantic codetools_0.2-2-1.dsc
I: codetools source: build-depends-without-arch-dep debhelper
I: codetools source: build-depends-without-arch-dep r-base-dev
I: codetools source: build-depends-without-arch-dep cdbs

$ frontend/lintian -I -E --pedantic codetools_0.2-2-1.dsc
$

Will commit once I've finished running through the test suite.

Regards,

Adam


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to