Bug#317910: libfilesys-diskfree-perl: does not wait() after forking

[Radu Muschevici]

Package: libfilesys-diskfree-perl
Version: 0.06-1.1
Severity: normal
Tags: patch


using your Perl module Filesys::DiskFree version 0.06 I found a bug:

In DiskFree.pm: method df() returns before closing HANDLE and thus the 
close statement is never reached. This results in not wait()-ing for the 
child to return, leaving a zombie behind.

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11.7
Locale: LANG=C, [EMAIL PROTECTED] (charmap=ISO-8859-15)

Versions of packages libfilesys-diskfree-perl depends on:
ii  perl                          5.8.7-3    Larry Wall's Practical Extraction 

libfilesys-diskfree-perl recommends no packages.

-- no debconf information

--- /usr/share/perl5/Filesys/DiskFree.pm        1998-10-24 00:30:01.000000000 
+0200
+++ ../lib/DiskFree.pm  2005-07-12 12:06:21.000000000 +0200
@@ -108,9 +108,8 @@
     
     $cmd=$self->command() or
        croak "No df command known for format ".$self->{'FORMAT'};
-    open(HANDLE,"$cmd|") or croak("Cannot fork $!");
-    return $self->load(\*HANDLE);
-    close(HANDLE) or croak("Cannot df $!");
+    open(my $HANDLE,"$cmd|") or croak("Cannot fork $!");
+    return $self->load($HANDLE);
 }
 
 sub load()  {
@@ -122,7 +121,7 @@
                $self->readline($_);
        }
     } else {
-       map { $self->readline($_) } split(/$\//,$handle);
+       map { $self->readline($_) } split(/\$\//,$handle);
     }
     return 'true';
 }