Package:  open-iscsi
Version:  1.0.485-2
Severity: important
Tags:     patch
User:     [email protected]
Usertags: incorrect-dependency incorrect-provides

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script. The dependencies are not correct.  The
daemon need /usr/ to be mounted, and thus need to depend on $remote_fs
both during boot and shutdown.  Also, the stop-open-iscsi script
depend on open-iscsi, while the open-iscsi script provide iscsi.  The
provide need to match the depend, and I suggest renaming the provide
to handle this.

I suspect the stop dependencies on sendsigs and networking for both
init.d scripts are redundant, but failed to understand why they were
listed in the first place and thus left them there.

<URL: 
http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html
 >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Without it, the init.d will start
to early in the boot sequence.

diff -ur open-iscsi-2.0.870~rc3-pere/debian/open-iscsi.init 
open-iscsi-2.0.870~rc3/debian/open-iscsi.init
--- open-iscsi-2.0.870~rc3-pere/debian/open-iscsi.init  2009-08-13 
22:25:53.000000000 +0200
+++ open-iscsi-2.0.870~rc3/debian/open-iscsi.init       2009-08-13 
22:29:35.000000000 +0200
@@ -1,7 +1,7 @@
 #! /bin/sh
 ### BEGIN INIT INFO
-# Provides:          iscsi
-# Required-Start:    $local_fs
+# Provides:          open-iscsi
+# Required-Start:    $remote_fs
 # Required-Stop:     $remote_fs sendsigs networking
 # Default-Start:     S
 # Default-Stop:      0 6

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to