Package: rebuildd Version: 0.3.5 Severity: important Tags: patch User: [email protected] Usertags: incorrect-dependency
Hi, While examining some init scripts I found rebuildd's to be missing some dependencies. Since the binary lives in /usr it requires $remote_fs (not just a should-). As for the $network part, since I'm not sure how rebuildd uses it I hesitated between keeping it in should- and required-. If rebuildd can not live without any network interface (including lo) then please move $network to required-. http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html documents the LSB header format. Some Debian notes are available at http://wiki.debian.org/LSBInitScripts This patch should solve the issue. Without it, the init.d will start too early in the boot sequence on some systems. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net
diff -urpN rebuildd-0.3.5.orig/debian/rebuildd.init.d rebuildd-0.3.5/debian/rebuildd.init.d --- rebuildd-0.3.5.orig/debian/rebuildd.init.d 2008-08-31 14:28:23.000000000 -0500 +++ rebuildd-0.3.5/debian/rebuildd.init.d 2009-08-14 13:22:07.548012387 -0500 @@ -3,10 +3,10 @@ # ### BEGIN INIT INFO # Provides: rebuildd -# Required-Start: -# Required-Stop: -# Should-Start: $local_fs $network -# Should-Stop: $local_fs $network +# Required-Start: $remote_fs +# Required-Stop: $remote_fs +# Should-Start: $network +# Should-Stop: $network # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: rebuild daemon diff -urpN rebuildd-0.3.5.orig/debian/rebuildd.rebuildd-httpd.init.d rebuildd-0.3.5/debian/rebuildd.rebuildd-httpd.init.d --- rebuildd-0.3.5.orig/debian/rebuildd.rebuildd-httpd.init.d 2008-08-31 14:28:40.000000000 -0500 +++ rebuildd-0.3.5/debian/rebuildd.rebuildd-httpd.init.d 2009-08-14 13:21:10.188072789 -0500 @@ -3,10 +3,10 @@ # ### BEGIN INIT INFO # Provides: rebuildd-httpd -# Required-Start: -# Required-Stop: -# Should-Start: $local_fs $network -# Should-Stop: $local_fs $network +# Required-Start: $remote_fs $network +# Required-Stop: $remote_fs $network +# Should-Start: +# Should-Stop: # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: rebuild daemon Web server
