On Mon, Aug 17, 2009 at 11:20:22PM +0200, Max Kellermann wrote:
> Can you make a "git bisect" from release-0.15.1 to release-0.15.2 to
> isolate the commit which broke playback for you? It's very difficult
> for me to find the cause, because I don't hear that problem over here.
This took longer than expected…
git bisect start
# bad: [5715534b530cfed0d6650b0fb34cfcb17da4088b] mpd version 0.15.2
git bisect bad 5715534b530cfed0d6650b0fb34cfcb17da4088b
# good: [d7bad6ae020ffabfd5d2ae9d2ce723e67e999077] mpd version 0.15.1
git bisect good d7bad6ae020ffabfd5d2ae9d2ce723e67e999077
# good: [cf1fd2b0da4be4675ddb16c5421d949a0e923b20] decoder/flac: return
early from flac_find_float_comment()
git bisect good cf1fd2b0da4be4675ddb16c5421d949a0e923b20
# good: [1c4f407a6db4c4795bbbc354f5cf311762fb8e33] decoder/flac: don't
allocate cuesheet twice (memleak)
git bisect good 1c4f407a6db4c4795bbbc354f5cf311762fb8e33
# good: [7dddd9beda2bb0505758bb6a32cae6feb3215733] directory: free empty
directories after removing them (memleak)
git bisect good 7dddd9beda2bb0505758bb6a32cae6feb3215733
# bad: [f38ce5408b5d0126b8cfe730c91d5203ee59a987] output/shout: minimize
the unpause latency
git bisect bad f38ce5408b5d0126b8cfe730c91d5203ee59a987
# bad: [7133f560ec24c90671a40c9f9bc9cea6eb31cc17] output: fixed shout stuck
pause bug
git bisect bad 7133f560ec24c90671a40c9f9bc9cea6eb31cc17
The commit which causes skipping audio is:
commit 7133f560ec24c90671a40c9f9bc9cea6eb31cc17
Author: Max Kellermann <[email protected]>
Date: Fri Aug 14 11:52:12 2009 +0200
output: fixed shout stuck pause bug
Explicitly make the output thread leave the ao_pause() loop. This
patch is a workaround, and the "pause" flag is not managed in a
thread-safe way, but that's good enough for now.
I had to do two complete bisects as the bug turned out to randomly
appear and disappear on each execution of mpd. The second round of git
bisect, however, revealed that all versions < 7133f56 were definitly
good, and all versions >= 7133f56 produced skipping playback on some
executions of mpd and smooth playback on others.
Reverting commit 7133f56 fixes the audio skips :-).
Čau,
Peter
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
