Package:  lsh-server
Version:  2.0.2-1.1
Severity: important
Tags:     patch
User:     [email protected]
Usertags: incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The provides used should be unique, and
the current one is in conflict with the openssh-server package.  If
the script use the same provides as the openssh-server, the same
effect can be achieved using reverse dependencies on the scripts
currently depending on sshd.  Checking all the scripts in the archive,
these are cman, drbd, smokeping and vz.  I'm not sure if all of them
are needed, but thought it best to include them all.  If the intention
was not to have the same provides as sshd, the reverse dependency is
not needed.

The script should run before all *dm
services, and thus should include a header to make sure that happen.
Without it, it can start to late in the boot sequence.  The only of
these script currently depending on xfs is xdm at the moment.  The
others should depend on it too. :)

<URL: 
http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html
 >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Without it, the lsh-server package
will fail to install when openssh-server is or has been installed on
the machine and not purged.

diff -ur lsh-utils-2.0.4-dfsg/debian/lsh-server.init.d 
lsh-utils-2.0.4-dfsg-pere/debian/lsh-server.init.d
--- lsh-utils-2.0.4-dfsg/debian/lsh-server.init.d       2009-08-20 
21:30:37.000000000 +0200
+++ lsh-utils-2.0.4-dfsg-pere/debian/lsh-server.init.d  2009-08-20 
21:35:06.000000000 +0200
@@ -6,9 +6,11 @@
 #

 ### BEGIN INIT INFO
-# Provides:          sshd
+# Provides:          lsh-server
 # Required-Start:    $local_fs $remote_fs $syslog $named $network
 # Required-Stop:     $local_fs $remote_fs $syslog $named $network
+# X-Start-Before:    cman drbd smokeping vz
+# X-Stop-After:      cman drbd smokeping vz
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: lsh secure shell server

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to