Package: knockd
Version: 0.5-1
Followup-For: Bug #299789

I'm not sure the logrotate script will work.

You are not telling knockd to close and reopen the logfile, so it will
keep writing to the old file, even after it was rotated.

Also, you are hardcoding the name of the logfile here, but it's
supposedly user-specified in the .conf script. The mis-match doesn't
seem like a good idea to me.

I suggest you move the configuration of the logfile to a command line
option, and specify it in the init.d script, rather then knockd.conf.
Let the user disable it (and/or enable syslog logging), but not change
the name of the logfile, via /etc/default/knockd

You need to provide a way to make knockd reopen the logfile - either
with a signal, or have it keep the logfile closed normally, and only
open it when needed. (Or just automatically close and reopen the logfile
once a day w/o being asked by setting an alarm in knockd.) The signal
method is traditional, and you can also have the same signal make knockd
re-read it's .conf file. Then you can enable init.d/knockd reload.

Also, I don't think the logrotate script should create the logfile - in
case the user decides he doesn't want logging. Have knockd create it,
with appropriate permissions.

-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.6.11
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages knockd depends on:
ii  libc6                       2.3.2.ds1-21 GNU C Library: Shared libraries an
ii  libpcap0.8                  0.8.3-5      System interface for user-level pa
ii  logrotate                   3.7-2        Log rotation utility

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to