----- Forwarded message from Joey Hess <[email protected]> ----- Date: Wed, 26 Aug 2009 17:28:12 -0400 From: Joey Hess <[email protected]> To: Christoph Fritz <[email protected]> Cc: [email protected] Subject: Re: wmbattery: [patch] add feature "-x command" User-Agent: Mutt/1.5.20 (2009-06-14)
Sorry for not looking at this the first time you sent it. Christoph Fritz wrote: > @@ -0,0 +1,106 @@ > +/* > + * command.c - execute specified command > + * > + * Copyright (C) 2009 Christoph Fritz <chris_honschu(at)gmx.de> > + * > + * License: see file GPL > + */ > +/* the function substitude_str is derived from Laird Shaw's > + * function replace_net. > + * > + * Laird Shaw <[email protected]> grant permission for > + * redistribution under a free license. > + * > + * http://members.dodo.com.au/~netocrat/c/source/replacebench.c I cannot find any indication of the replacebench file being licensed, or what the free license would be, so using code derived from it is questionable unless you directly contacted the author. Which seems like a lot of work for such a fairly simple C function. :) > +char *substitude_str(const char *in_str, const char *old_str, This should be spelt "substitute", FWIW. > +Execute the specified command in an intervall mode when the battery is below What is an "intervall mode" ? > @@ -261,6 +264,9 @@ char *parse_commandline(int argc, char *argv[]) { > case 'a': > crit_audio_fn = strdup(optarg); > break; > + case 'x': > + crit_command = strdup(optarg); > + break; > } Pretty clear looking at the patch that your indentation doesn't match (your're not using tabs here). -- see shy jo ----- End forwarded message ----- -- see shy jo
signature.asc
Description: Digital signature
